Skip to content

add ssh_key_ids property for Volume entity#5

Merged
hi-lei merged 2 commits intoverda-cloud:masterfrom
hi-lei:feature/Feature-351-add-ssh-key-ids-to-os-volume
Dec 17, 2021
Merged

add ssh_key_ids property for Volume entity#5
hi-lei merged 2 commits intoverda-cloud:masterfrom
hi-lei:feature/Feature-351-add-ssh-key-ids-to-os-volume

Conversation

@hi-lei
Copy link
Copy Markdown
Contributor

@hi-lei hi-lei commented Dec 17, 2021

deploy a new instance with os_volume attached

deploy a new instance with os_volume attached
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 17, 2021

Codecov Report

Merging #5 (95f88c0) into master (8d2b50e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files          15       15           
  Lines         567      571    +4     
=======================================
+ Hits          563      567    +4     
  Misses          4        4           
Impacted Files Coverage Δ
datacrunch/instances/instances.py 98.01% <ø> (ø)
datacrunch/volumes/volumes.py 100.00% <100.00%> (ø)
datacrunch/startup_scripts/startup_scripts.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d2b50e...95f88c0. Read the comment docs.

Copy link
Copy Markdown
Collaborator

@tamirse tamirse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hi-lei hi-lei merged commit 7392161 into verda-cloud:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants